Skip to content

fix: remove lazy loading for deprecated inferenceAccelerators property #35080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rantoniuk
Copy link
Contributor

Follow-up of #34618 as it did not fully fix the warnings.

Change

Since the related property is deprecated anyway, removing the lazy loader usage is the simplest fix.

Tests

Tested on minimal stack and an actual production stack.

Fixes #34895

@Copilot Copilot AI review requested due to automatic review settings July 27, 2025 19:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes lazy loading for the deprecated inferenceAccelerators property in ECS task definitions to eliminate warnings. The change simplifies the code by directly evaluating the inference accelerators condition instead of wrapping it in a lazy loader.

  • Replaces lazy-loaded inferenceAccelerators with direct evaluation
  • Maintains the same conditional logic for Fargate compatibility
  • Addresses deprecation warnings from the lazy loading mechanism

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jul 27, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 27, 2025 19:18
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@rantoniuk
Copy link
Contributor Author

Exemption Request - as previously, I don't think this needs tests.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jul 27, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 594ce5e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rantoniuk rantoniuk marked this pull request as draft July 28, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-ecs: aws-cdk-lib.aws_ecs.CfnTaskDefinitionProps#inferenceAccelerators deprecation warning
2 participants