[v2] Upgrade prompt-toolkit to 3.0.51 #9552
Open
+230
−237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9453
Upgrades
prompt-toolkit
ceiling to 3.0.51.prompt-toolkit
began identifying its package version usingimportlib.metadata
[source]. This is increasingly becoming a common pattern so I made a couple long-term decisions to unblock the upgrade.botocore
ands3transfer
were vended so that existing code wouldn't need to update its imports. This preventsprompt-toolkit
's metadata from being found at build time and runtime. I fixed this by instead inserting the custom wrapped import finder before the default import finder. So imports will continue working as it always has, but if it fails to load metadata, it'll fall back to the default import finder. I think in the long term we should just remove the custom import finder code altogether and make the effort to update imports (egimport botocore
->import awscli.botocore
.dist.info
directories. Our build code was intentionally removing these files from the final distribution because they were unnecessary at the time. I removed that logic since we now need package metadata at runtime.