-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New CLI examples for EKS #9576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New CLI examples for EKS #9576
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9576 +/- ##
========================================
Coverage 93.40% 93.40%
========================================
Files 211 211
Lines 17012 17020 +8
========================================
+ Hits 15890 15898 +8
Misses 1122 1122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting AWS CLI command examples.
Please complete the requested changes, commit your updates, rebase and push to the PR.
@@ -0,0 +1,29 @@ | |||
**To associate an access policy and its scope to the access entry of the cluster** | |||
|
|||
The following `associate-access-policy` associates an access policy and its scope to the access entry of the specified cluster. :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following `associate-access-policy` associates an access policy and its scope to the access entry of the specified cluster. :: | |
The following ``associate-access-policy`` associates an access policy and its scope to the access entry of the specified cluster. :: |
Output:: | ||
|
||
{ | ||
"clusterName": "eks-customer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"clusterName": "eks-customer", | |
"clusterName": "eks-customer", |
The indenting on all the JSON output needs to be fixed. There are parts that need an additional 4 space indent.
https://aws.github.io/aws-cli/docs_styleguide.html#general
Output:: | ||
|
||
{ | ||
"accessEntry": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, output indenting needs to be fixed.
https://aws.github.io/aws-cli/docs_styleguide.html#general
Output:: | ||
|
||
{ | ||
"accessEntry": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here for output.
@@ -0,0 +1,59 @@ | |||
**Example 1: To create an EKS Pod Identity association in EKS cluster** | |||
|
|||
The following `create-pod-identity-association` example creates an EKS Pod Identity association between a service account in the EKS cluster and an IAM role. :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following `create-pod-identity-association` example creates an EKS Pod Identity association between a service account in the EKS cluster and an IAM role. :: | |
The following ``create-pod-identity-association`` example creates an EKS Pod Identity association between a service account in the EKS cluster and an IAM role. :: |
Output:: | ||
|
||
{ | ||
"associations": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here for output.
@@ -0,0 +1,28 @@ | |||
**To update an access entry for an EKS cluster** | |||
|
|||
The following `update-access-entry` updates an access entry for the EKS cluster by adding the Kubernetes group `tester`. :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following `update-access-entry` updates an access entry for the EKS cluster by adding the Kubernetes group `tester`. :: | |
The following ``update-access-entry`` updates an access entry for the EKS cluster by adding the Kubernetes group ``tester``. :: |
Output:: | ||
|
||
{ | ||
"accessEntry": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here for output.
@@ -0,0 +1,29 @@ | |||
**To update the EKS Pod Identity association** | |||
|
|||
The following `update-pod-identity-association` example updates an EKS Pod Identity association by changing the associated IAM role from `arn:aws:iam::111122223333:role/my-role` to `arn:aws:iam::111122223333:role/s3-role` for association ID `a-9njjin9gfghecgocd`. This API only allows updating the associated IAM role. :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following `update-pod-identity-association` example updates an EKS Pod Identity association by changing the associated IAM role from `arn:aws:iam::111122223333:role/my-role` to `arn:aws:iam::111122223333:role/s3-role` for association ID `a-9njjin9gfghecgocd`. This API only allows updating the associated IAM role. :: | |
The following ``update-pod-identity-association`` example updates an EKS Pod Identity association by changing the associated IAM role from ``arn:aws:iam::111122223333:role/my-role`` to ``arn:aws:iam::111122223333:role/s3-role`` for association ID ``a-9njjin9gfghecgocd``. This API only allows updating the associated IAM role. :: |
Output:: | ||
|
||
{ | ||
"association": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here for output.
1ddcf9a
to
2f8e0bd
Compare
Thanks, @elysahall. I completed the changes and rebased. |
2f8e0bd
to
986d357
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sending for maintainer review.
* release-1.41.8: Bumping version to 1.41.8 Update changelog based on model updates New CLI examples for EKS (#9576)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.