Skip to content

New CLI examples for EKS #9576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

Conversation

daniil-millwood
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hssyoo hssyoo self-assigned this Jun 30, 2025
@hssyoo hssyoo added the documentation This is a problem with documentation. label Jun 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.40%. Comparing base (68039fa) to head (e4a5d9f).
Report is 108 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9576   +/-   ##
========================================
  Coverage    93.40%   93.40%           
========================================
  Files          211      211           
  Lines        17012    17020    +8     
========================================
+ Hits         15890    15898    +8     
  Misses        1122     1122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@elysahall elysahall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting AWS CLI command examples.

Please complete the requested changes, commit your updates, rebase and push to the PR.

@@ -0,0 +1,29 @@
**To associate an access policy and its scope to the access entry of the cluster**

The following `associate-access-policy` associates an access policy and its scope to the access entry of the specified cluster. ::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following `associate-access-policy` associates an access policy and its scope to the access entry of the specified cluster. ::
The following ``associate-access-policy`` associates an access policy and its scope to the access entry of the specified cluster. ::

Output::

{
"clusterName": "eks-customer",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"clusterName": "eks-customer",
"clusterName": "eks-customer",

The indenting on all the JSON output needs to be fixed. There are parts that need an additional 4 space indent.
https://aws.github.io/aws-cli/docs_styleguide.html#general

Output::

{
"accessEntry": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, output indenting needs to be fixed.
https://aws.github.io/aws-cli/docs_styleguide.html#general

Output::

{
"accessEntry": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here for output.

@@ -0,0 +1,59 @@
**Example 1: To create an EKS Pod Identity association in EKS cluster**

The following `create-pod-identity-association` example creates an EKS Pod Identity association between a service account in the EKS cluster and an IAM role. ::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following `create-pod-identity-association` example creates an EKS Pod Identity association between a service account in the EKS cluster and an IAM role. ::
The following ``create-pod-identity-association`` example creates an EKS Pod Identity association between a service account in the EKS cluster and an IAM role. ::

Output::

{
"associations": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here for output.

@@ -0,0 +1,28 @@
**To update an access entry for an EKS cluster**

The following `update-access-entry` updates an access entry for the EKS cluster by adding the Kubernetes group `tester`. ::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following `update-access-entry` updates an access entry for the EKS cluster by adding the Kubernetes group `tester`. ::
The following ``update-access-entry`` updates an access entry for the EKS cluster by adding the Kubernetes group ``tester``. ::

Output::

{
"accessEntry": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here for output.

@@ -0,0 +1,29 @@
**To update the EKS Pod Identity association**

The following `update-pod-identity-association` example updates an EKS Pod Identity association by changing the associated IAM role from `arn:aws:iam::111122223333:role/my-role` to `arn:aws:iam::111122223333:role/s3-role` for association ID `a-9njjin9gfghecgocd`. This API only allows updating the associated IAM role. ::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following `update-pod-identity-association` example updates an EKS Pod Identity association by changing the associated IAM role from `arn:aws:iam::111122223333:role/my-role` to `arn:aws:iam::111122223333:role/s3-role` for association ID `a-9njjin9gfghecgocd`. This API only allows updating the associated IAM role. ::
The following ``update-pod-identity-association`` example updates an EKS Pod Identity association by changing the associated IAM role from ``arn:aws:iam::111122223333:role/my-role`` to ``arn:aws:iam::111122223333:role/s3-role`` for association ID ``a-9njjin9gfghecgocd``. This API only allows updating the associated IAM role. ::

Output::

{
"association": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here for output.

@elysahall elysahall added the pr:work-in-progress This PR is a draft and needs further work. label Jul 2, 2025
@elysahall elysahall self-assigned this Jul 2, 2025
@daniil-millwood
Copy link
Contributor Author

Thanks, @elysahall. I completed the changes and rebased.

@hssyoo hssyoo added needs-review This issue or pull request needs review from a core team member. pr:needs-review This PR needs a review from a Member. and removed pr:work-in-progress This PR is a draft and needs further work. needs-review This issue or pull request needs review from a core team member. labels Jul 14, 2025
Copy link
Collaborator

@elysahall elysahall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sending for maintainer review.

@github-actions github-actions bot mentioned this pull request Jul 16, 2025
2 tasks
@hssyoo hssyoo merged commit 7a590b3 into aws:develop Jul 17, 2025
40 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Jul 17, 2025
* release-1.41.8:
  Bumping version to 1.41.8
  Update changelog based on model updates
  New CLI examples for EKS (#9576)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. pr:needs-review This PR needs a review from a Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants