Skip to content

Update aws_zsh_completer.sh #9579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update aws_zsh_completer.sh #9579

wants to merge 1 commit into from

Conversation

rrotter
Copy link

@rrotter rrotter commented Jun 28, 2025

Issue #, if available:
n/a

Description of changes:

  • remove -i flag from bashcompinit: this command takes no flags, the flag has no effect (see: https://github.com/zsh-users/zsh/blob/master/Completion/bashcompinit, it contains no argument parsing at all)
  • remove patching of _bash_complete: this was patched in zsh 5.0.3 which was released in 2013; no OS or package manager has shipped a zsh this old in 10+ years
  • only run bashcompinit if it hasn't been run already: there are plenty of other bash only completers; re-running bashcompinit for each one is unnecessary and slows down shell initialization

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- remove `-i` flag from `bashcompinit`: this command takes no flags, the flag has no effect
- remove patching of _bash_complete: this was patched in zsh 5.0.3 which was released in 2013
- only run bashcompinit if it hasn't been run already
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant