test(examples): add example for DDB Global Table v2017 #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecorella
requested changes
Dec 9, 2021
| import org.testng.annotations.Test; | ||
|
|
||
| public class AwsKmsMultiRegionKeyGlobal2017IT { | ||
| private static final String TABLE_NAME = "tonyknap-manual-mrk-global-2017"; |
There was a problem hiding this comment.
more generic table name, since this goes to our examples? "I think TableName" or "SuperCoolTable" are worthy candidates?
There was a problem hiding this comment.
I do not think we ever going to ship this... but if we did, yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #68, #69, #70
Description of changes: Add an example that demonstrates using an MRK with a DynamoDB Global v2017 table.
This does not address the features requested in the issues (#68 , #69 , or #70 ) but does demonstrate a work around.
Since those feature requests have been created, DynamoDB has improved Global tables with version 2019.11.21.
As such, I believe that we should close those issues, referencing this Pull Request as the work around for any customers still using Global tables version 2017.11.29.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: