bugfix: Prevent errors thrown inside passed in callback to be mistake… #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly reported as verification error Actual signature verification and result of verification is occuring inside try catch block. For some reason user passed callback function throws an error it is being reported as verification error and also it causes the callback to be called twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nly reported as verification error
Actual signature verification and result of verification is occurring inside try catch block. If user passed callback throws an exception then it is reported as verification error, and it also causes the callback to be called twice.
Issue #, if available:
Description of changes:
Took out callback call from try catch block
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.