feat: Python UV workflow #756
Conversation
sriram-mv
force-pushed
the
python-uv
branch
2 times, most recently
from
b89aa89 to
ec932ce
Compare
Core Features: * Intelligent handling of pyproject.toml with automatic uv.lock detection * Multi-format support: pyproject.toml, requirements.txt, and requirements-*.txt variants * Lock file optimization: Automatic uv.lock usage for reproducible builds when available * Platform targeting: Lambda-compatible builds for x86_64 and ARM64 architectures * Python version control: Precise Python version targeting via UV's --python flags UV Functionality: * `uv sync --python X.Y` for lock-based builds (pyproject.toml + uv.lock) * `uv lock && uv export` workflow for pyproject.toml without lock files * `uv pip install --python-version X.Y --python-platform` for requirements.txt * Proper virtual environment handling and site-packages extraction Documentation: * Complete DESIGN.md with architecture overview and usage patterns * Accurate API documentation reflecting constructor + method call pattern * Smart dispatch logic clearly explained with examples * Updated to match actual implementation (no outdated references) Compatibility: * Compatible with existing Lambda Builders interface * Supports standard build parameters (source_dir, artifacts_dir, scratch_dir) * Runtime parameter properly extracted and used for Python version targeting * Architecture parameter mapped to UV platform specifications
| - name: Install UV | ||
| uses: astral-sh/setup-uv@v4 | ||
| with: | ||
| enable-cache: true |
There was a problem hiding this comment.
Can we separate jobs for python-uv and python-pip, like we do for Java with Maven and Gradle. It would be easier to identify which tool caused failure.
| class MissingUvError(LambdaBuilderError): | ||
| """Exception raised when UV executable is not found.""" | ||
|
|
||
| MESSAGE = "uv executable not found in your environment. Please install uv: https://docs.astral.sh/uv/getting-started/installation/" |
There was a problem hiding this comment.
Can we also print the {uv_path} in the message, to mention the specific location where the uv executable was not found.
| artifacts_dir_path: str, | ||
| scratch_dir_path: str, | ||
| manifest_path: str, | ||
| architecture: str = X86_64, |
There was a problem hiding this comment.
Why did we hardcode the architecture here?
| handler = self._get_manifest_handler(manifest_name) | ||
|
|
||
| # Execute the handler | ||
| handler(manifest_path, artifacts_dir_path, scratch_dir_path, python_version, architecture, config) |
There was a problem hiding this comment.
Where is this method actually building the dependencies? For reference here is how python pip handles building the dependencies.
| except Exception as e: | ||
| raise UvBuildError(reason=f"Failed to build from pyproject.toml: {str(e)}") | ||
|
|
||
| def _export_pyproject_to_requirements( |
There was a problem hiding this comment.
Why are we converting pyproject.toml to requirements.txt, when it is recommended t o use pyproject.toml to define dependencies for UV?
| MESSAGE = "Lock file operation failed: {reason}" | ||
|
|
||
|
|
||
| class ManifestNotFoundError(LambdaBuilderError): |
There was a problem hiding this comment.
Where have we used this exception?
| MESSAGE = "Failed to install dependencies using uv: {reason}" | ||
|
|
||
|
|
||
| class UvResolutionError(LambdaBuilderError): |
There was a problem hiding this comment.
Where have we used this exception?
| @patch("aws_lambda_builders.workflows.python_uv.packager.OSUtils") | ||
| def test_subprocess_uv_init_missing_uv(self, mock_osutils_class): | ||
| mock_osutils = Mock() | ||
| mock_osutils.which.return_value = None |
There was a problem hiding this comment.
Can we just keep the path here /usr/bin/
Issue link: #743
Core Features:
UV Functionality:
uv sync --python X.Yfor lock-based builds (pyproject.toml + uv.lock)uv lock && uv exportworkflow for pyproject.toml without lock filesuv pip install --python-version X.Y --python-platformfor requirements.txtDocumentation:
Compatibility:
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.