Skip to content

Skip aws-lc-rs "publish dryrun" job when -sys crates not published #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jul 11, 2025

Description of changes:

  • When the version numbers of the sys crates change in the repo, but haven't been published yet, the publish dryrun for aws-lc-rs fails.

Testing

Output of version check ...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.39%. Comparing base (c358484) to head (f094ac9).
Report is 232 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   95.80%   92.39%   -3.41%     
==========================================
  Files          61       71      +10     
  Lines        8143     9065     +922     
  Branches        0     9065    +9065     
==========================================
+ Hits         7801     8376     +575     
- Misses        342      423      +81     
- Partials        0      266     +266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the ci-publish-dryrun-fix branch 8 times, most recently from a47b00d to 2bb0f0c Compare July 11, 2025 17:28
@justsmth justsmth force-pushed the ci-publish-dryrun-fix branch from 2bb0f0c to f094ac9 Compare July 11, 2025 17:46
@justsmth justsmth requested a review from skmcgrail July 11, 2025 18:35
@justsmth justsmth marked this pull request as ready for review July 11, 2025 18:35
@justsmth justsmth requested a review from a team as a code owner July 11, 2025 18:35
@justsmth justsmth changed the title [DRAFT] Fix publish dryrun when -sys crates update Fix publish dryrun when -sys crates update Jul 11, 2025
@justsmth justsmth changed the title Fix publish dryrun when -sys crates update Skip aws-lc-rs "publish dryrun" job when -sys crates not published Jul 11, 2025
@samuel40791765 samuel40791765 self-requested a review July 15, 2025 17:13
@justsmth justsmth merged commit 78258d2 into aws:main Jul 15, 2025
289 checks passed
@justsmth justsmth deleted the ci-publish-dryrun-fix branch July 15, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants