Create pre-production stage for CI pipeline #2282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2282 +/- ##
==========================================
- Coverage 78.89% 78.89% -0.01%
==========================================
Files 621 621
Lines 108670 108670
Branches 15419 15421 +2
==========================================
- Hits 85739 85732 -7
- Misses 22260 22268 +8
+ Partials 671 670 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nhatnghiho
force-pushed
the
ci-pipeline
branch
2 times, most recently
from
267feb5 to
b100ece
Compare
nhatnghiho
force-pushed
the
ci-pipeline
branch
3 times, most recently
from
3f82970 to
edbd376
Compare
skmcgrail
reviewed
Apr 2, 2025
andrewhop
reviewed
Apr 8, 2025
| else {} | ||
| ) | ||
|
|
||
| @jsii.member(jsii_name="produceAction") |
There was a problem hiding this comment.
Yeah, is there some functionality missing in the Python CDK? Have we given feedback to them about it
skmcgrail
reviewed
Apr 24, 2025
andrewhop
reviewed
Apr 25, 2025
andrewhop
previously approved these changes
May 16, 2025
skmcgrail
previously approved these changes
May 20, 2025
andrewhop
previously approved these changes
May 20, 2025
skmcgrail
previously approved these changes
May 20, 2025
skmcgrail
previously approved these changes
May 20, 2025
andrewhop
previously approved these changes
May 21, 2025
andrewhop
approved these changes
May 21, 2025
skmcgrail
approved these changes
May 22, 2025
Merged
justsmth
added a commit
that referenced
this pull request
May 29, 2025
## What's Changed * Increase default salt from 8 to 16 bytes for PKCS#8 & PKCS#12 by @xnox in #2409 * fix(nix): Make sure bssl is in the PATH; workaround nix build failure… by @dougch in #2431 * Fix path-has-spaces test by @justsmth in #2436 * Create pre-production stage for CI pipeline by @nhatnghiho in #2282 * Fix CI cross-mingw by @justsmth in #2437 * Display X509 fingerprint after hash by @justsmth in #2444 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #CryptoAlg-2983 and #CryptoAlg-2984
Description of changes:
This PR implements steps to deploy to pre-production in the CI pipeline, which will act as template for production deployment later on. The PR also sets up a dev deployment environment for testing purposes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.