Create pre-production stage for CI pipeline #2282
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2282 +/- ##
==========================================
+ Coverage 79.02% 79.05% +0.02%
==========================================
Files 614 614
Lines 106934 107058 +124
Branches 15145 15162 +17
==========================================
+ Hits 84504 84634 +130
+ Misses 21777 21771 -6
Partials 653 653 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nhatnghiho
force-pushed
the
ci-pipeline
branch
2 times, most recently
from
267feb5 to
b100ece
Compare
nhatnghiho
force-pushed
the
ci-pipeline
branch
3 times, most recently
from
3f82970 to
edbd376
Compare
| image: 620771051181.dkr.ecr.us-west-2.amazonaws.com/aws-lc-docker-images-linux-x86:ubuntu-20.04_clang-7x-bm-framework_latest | ||
| image: 183295444613.dkr.ecr.us-west-2.amazonaws.com/aws-lc-docker-images-linux-x86:ubuntu-20.04_clang-7x-bm-framework_latest |
There was a problem hiding this comment.
Should remain as the team account
| image: 620771051181.dkr.ecr.us-west-2.amazonaws.com/aws-lc-docker-images-linux-x86:ubuntu-20.04_clang-7x-bm-framework_latest | ||
| image: 183295444613.dkr.ecr.us-west-2.amazonaws.com/aws-lc-docker-images-linux-x86:ubuntu-20.04_clang-7x-bm-framework_latest |
There was a problem hiding this comment.
Should remain as the team account
| image: 620771051181.dkr.ecr.us-west-2.amazonaws.com/aws-lc-docker-images-linux-x86:ubuntu-20.04_clang-7x-bm-framework_latest | ||
| image: 183295444613.dkr.ecr.us-west-2.amazonaws.com/aws-lc-docker-images-linux-x86:ubuntu-20.04_clang-7x-bm-framework_latest |
There was a problem hiding this comment.
Should remain as the team account
| image: 620771051181.dkr.ecr.us-west-2.amazonaws.com/aws-lc-docker-images-linux-x86:ubuntu-20.04_clang-7x-bm-framework_latest | ||
| image: 183295444613.dkr.ecr.us-west-2.amazonaws.com/aws-lc-docker-images-linux-x86:ubuntu-20.04_clang-7x-bm-framework_latest |
There was a problem hiding this comment.
Should remain as the team account
| if env.account == PRE_PROD_ACCOUNT: | ||
| github_repo_owner = STAGING_GITHUB_REPO_OWNER | ||
| github_repo_name = STAGING_GITHUB_REPO_NAME |
There was a problem hiding this comment.
How does this work for deploying to your own personal account if you want to go through setting up the pipeline and all that?
There was a problem hiding this comment.
I guess these are correctly set to the values from the pipeline cdk_env in AwsLcCiPipeline?
| while [[ ${attempt} -le ${MAX_RETRY} ]]; do | ||
| if [[ $attempt -gt 0 ]]; then | ||
| echo "Retrying ${attempt}/${MAX_RETRY}..." | ||
| fi | ||
|
|
||
| attempt=$((attempt + 1)) | ||
|
|
|
|
||
| assume_role | ||
|
|
||
| if [[ -z "${BUILD_TYPE+x}" || -z "${BUILD_TYPE}" ]]; then |
There was a problem hiding this comment.
| if [[ -z "${BUILD_TYPE+x}" || -z "${BUILD_TYPE}" ]]; then | |
| if [[ -z "${BUILD_TYPE:+x}" ]]; then |
Does both of these for you. If BUILD_TYPE is either unset / empty string or not defined it will be a empty string substituted for this check. Otherwise x will be substituted and thus not move into the if statement body.
| fi | ||
|
|
||
| if [[ ${BUILD_TYPE} == "docker" ]]; then | ||
| if [[ -z "${PLATFORM+x}" || -z "${PLATFORM}" ]]; then |
| fi | ||
|
|
||
| if [[ ${BUILD_TYPE} == "ci" ]]; then | ||
| if [[ -z "${PROJECT+x}" || -z "${PROJECT}" ]]; then |
| if [[ -z "${BUILD_TYPE+x}" || -z "${BUILD_TYPE}" ]]; then | ||
| echo "No build type provided." | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ -z "${STACKS+x}" || -z "${STACKS}" ]]; then | ||
| echo "No stacks provided." | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ -n "${PREVIOUS_REBUILDS+x}" && -n "${PREVIOUS_REBUILDS}" ]]; then |
Issues:
Resolves #CryptoAlg-2983 and #CryptoAlg-2984
Description of changes:
This PR implements steps to deploy to pre-production in the CI pipeline, which will act as template for production deployment later on. The PR also sets up a dev deployment environment for testing purposes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.