Skip to content

Prepare Docker images for upcoming CI changes #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 17, 2025

Conversation

nhatnghiho
Copy link
Contributor

@nhatnghiho nhatnghiho commented Jun 6, 2025

Issues:

Addresses CryptoAlg-2907, CryptoAlg-3113, and P257046914

Description of changes:

This PR bundles a few Docker image changes together:

  • Added a few packages to our Linux images that's needed for Unbound and Bind9 CI.
  • Updated all Windows images to Windows 2022 so that we can upgrade our CodeBuild compute type and migrate MSVC-SDE-64-bit to CodeBuild. This is because MSVC-SDE-64-bit needs a lot of compute power. Also added an MSVC 2022 image to be used for this test migration.

Callouts:

  • Updating all Windows images to Windows 2022 means that our existing Windows CI tests in CodeBuild will now be run on Windows 2022, which should be okay because the MSVC version is still the same.
  • Running MSVC-SDE-64-bit on Windows 2022 will require disabling 5 CPUs that don't support AVX instructions, which Windows 2022 natively use. But Windows 2022 is our only easy path to migration because MSVC-SDE-64-bit is resource-intensive and requires at least a compute type of BUILD_GENERAL1_2XLARGE that is only available for Windows Server 2022 on CodeBuild.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (1b9a956) to head (0247223).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2475      +/-   ##
==========================================
- Coverage   78.89%   78.69%   -0.21%     
==========================================
  Files         640      644       +4     
  Lines      109755   110503     +748     
  Branches    15526    15643     +117     
==========================================
+ Hits        86590    86958     +368     
- Misses      22467    22844     +377     
- Partials      698      701       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nhatnghiho nhatnghiho force-pushed the docker-image-update branch from 6cf898b to 0da0471 Compare July 3, 2025 00:44
@nhatnghiho nhatnghiho force-pushed the docker-image-update branch from 0da0471 to 118556f Compare July 3, 2025 05:28
@nhatnghiho nhatnghiho marked this pull request as ready for review July 3, 2025 16:51
@nhatnghiho nhatnghiho requested a review from a team as a code owner July 3, 2025 16:51
@nhatnghiho nhatnghiho requested a review from samuel40791765 July 7, 2025 17:07
@nhatnghiho nhatnghiho merged commit 7d4905f into aws:main Jul 17, 2025
122 of 125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants