Add production stage to CI pipeline #2483
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2483 +/- ##
==========================================
- Coverage 78.85% 78.85% -0.01%
==========================================
Files 640 640
Lines 109604 109604
Branches 15525 15512 -13
==========================================
- Hits 86432 86424 -8
- Misses 22474 22483 +9
+ Partials 698 697 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| # Pipeline is run everytime we push to main branch. Avoid unnecessary hold up if these updates are non-CI related | ||
| if not IS_DEV: | ||
| start_index = next( | ||
| (i for i, stage in enumerate(base_pipeline.stages) if stage.stage_name == "PromoteToProduction"), #TODO: Revert this | ||
| None | ||
| ) |
There was a problem hiding this comment.
I don't follow what this is doing or what the impact is, also do you have an issue for this TODO so we don't forget?
There was a problem hiding this comment.
The TODO is redundant, I'll remove that.
But the idea is -- the pipeline is run everytime we push to main branch. With every stage, we would check to see if we need to redeploy. However, the manual approval step doesn't have such check. The pipeline will just sit and wait at the manual approval step until we approve it. This will lead to a pile of irrelevant pipeline executions stuck waiting at this step. That's why I put in the skip condition for this manual approval step so we can silently skip it (and since I'm at it already, when the manual approval step is skipped, I also configure the pipeline to skip all the subsequent production stages)
| # Create date-based tag | ||
| img_push_date=$(date +%Y-%m-%d) | ||
| if [[ -n "${PLATFORM:-}" && ${PLATFORM} == "windows" ]]; then | ||
| img_push_date=$(date +%Y-%m-%d-%H) | ||
| fi | ||
| date_tag="${tag%_latest}_${img_push_date}" |
There was a problem hiding this comment.
This creates today's tag which will be different than the pre-prod image, is there anyway to connect a prod image to the pre-prod image it came from?
There was a problem hiding this comment.
Updated code to reflect this. Since our images have a lifecycle of 30 days though, which depends on the time the images are published to ECR, the date tag and the expiration time will not correspond to each other. But preserving the date tag would make it easier for debugging.
Issues:
Resolves #CryptoAlg-2985
Description of changes:
Enable production stage for the CI pipeline with a few upgrades:
Testing:
Test deploy the pipeline using instructions in README
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.