-
Notifications
You must be signed in to change notification settings - Fork 136
Migrate Openssl-tool parameter parsing #2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2501 +/- ##
==========================================
- Coverage 78.69% 78.65% -0.04%
==========================================
Files 644 644
Lines 110480 110538 +58
Branches 15638 15644 +6
==========================================
+ Hits 86938 86946 +8
- Misses 22844 22902 +58
+ Partials 698 690 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b647173
to
cbb86b8
Compare
Good catch. I updated the "rsa" command to look for specific options, which is only "-modulus" currently, when generating its output. |
cbb86b8
to
4f2f398
Compare
8639f9f
to
d633a37
Compare
11e95f8
to
2930420
Compare
2930420
to
d3f96a6
Compare
Description of changes:
Follow-up from previous PR: #2454
ordered_args
for parameter processing.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.