Skip to content

Migrate Openssl-tool parameter parsing #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

justsmth
Copy link
Contributor

Description of changes:

Follow-up from previous PR: #2454

  • Migrates the remainder of the subcommands to using ordered_args for parameter processing.
  • Updates tests for rsa and crl to use reordered arguments.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 59.25926% with 44 lines in your changes missing coverage. Please review.

Project coverage is 78.65%. Comparing base (898e70c) to head (d3f96a6).

Files with missing lines Patch % Lines
tool-openssl/rsa_test.cc 11.11% 16 Missing ⚠️
tool-openssl/crl_test.cc 25.00% 9 Missing ⚠️
tool-openssl/s_client.cc 0.00% 6 Missing ⚠️
tool-openssl/rsa.cc 76.19% 5 Missing ⚠️
tool-openssl/crl.cc 84.61% 4 Missing ⚠️
tool-openssl/req.cc 0.00% 2 Missing ⚠️
tool-openssl/version.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2501      +/-   ##
==========================================
- Coverage   78.69%   78.65%   -0.04%     
==========================================
  Files         644      644              
  Lines      110480   110538      +58     
  Branches    15638    15644       +6     
==========================================
+ Hits        86938    86946       +8     
- Misses      22844    22902      +58     
+ Partials      698      690       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth changed the title Tool param order Openssl-tool subcommands all respect parameter order Jun 23, 2025
@justsmth justsmth marked this pull request as ready for review June 23, 2025 21:31
@justsmth justsmth requested a review from a team as a code owner June 23, 2025 21:31
Copy link
Contributor

@smittals2 smittals2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't very consistent on openssl's part, but I don't think RSA is one of the cli tools that honors ordering in output. I haven't verified the other tools though

Screenshot 2025-06-24 at 3 27 51 PM

samuel40791765
samuel40791765 previously approved these changes Jun 24, 2025
@justsmth
Copy link
Contributor Author

justsmth commented Jul 9, 2025

This isn't very consistent on openssl's part, but I don't think RSA is one of the cli tools that honors ordering in output. I haven't verified the other tools though

Good catch. I updated the "rsa" command to look for specific options, which is only "-modulus" currently, when generating its output.

@justsmth justsmth changed the title Openssl-tool subcommands all respect parameter order Openssl-tool subcommands (almost) all respect parameter order Jul 9, 2025
@justsmth justsmth changed the title Openssl-tool subcommands (almost) all respect parameter order Some Openssl-tool subcommands respect parameter order Jul 9, 2025
@justsmth justsmth changed the title Some Openssl-tool subcommands respect parameter order Migrate Openssl-tool parameter parsing Jul 10, 2025
@justsmth justsmth requested a review from smittals2 July 10, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants