cpu_ppc64le.c: fix build on FreeBSD #2520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,7 +69,11 @@ extern uint8_t OPENSSL_cpucap_initialized; | |||
|
|
|||
| void OPENSSL_cpuid_setup(void) { | |||
| #if defined(AT_HWCAP2) | |||
| #if defined(__linux__) | |||
There was a problem hiding this comment.
Please use OPENSSL_<OS> from https://github.com/aws/aws-lc/blob/main/include/openssl/target.h
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2520 +/- ##
==========================================
+ Coverage 78.88% 78.90% +0.01%
==========================================
Files 640 640
Lines 109755 109766 +11
Branches 15523 15526 +3
==========================================
+ Hits 86580 86608 +28
+ Misses 22478 22463 -15
+ Partials 697 695 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FreeBSD uses elf_aux_info() function instead of getauxval():
In file included from /wrkdirs/usr/ports/security/rustls-ffi/work/rustls-ffi-0.15.0/cargo-crates/aws-lc-sys-0.24.0/aws-lc/crypto/fipsmodule/bcm.c:86:
/wrkdirs/usr/ports/security/rustls-ffi/work/rustls-ffi-0.15.0/cargo-crates/aws-lc-sys-0.24.0/aws-lc/crypto/fipsmodule/cpucap/cpu_ppc64le.c:72:28: error: call to undeclared function 'getauxval'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
72 | OPENSSL_ppc64le_hwcap2 = getauxval(AT_HWCAP2);
| ^
|
Can you confirm that this patch works for your build environment? |
dkostic
approved these changes
Jul 9, 2025
justsmth
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD uses elf_aux_info() function instead of getauxval():
Description of changes:
Currently aws-lc doesn't build on FreeBSD/powerpc64* because of using getauxval(). This PR addresses the issue.
Testing:
Try building on FreeBSD 14.3-RELEASE on powerpc64le and powerpc64.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.