Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix validate error message #7961

Merged
merged 2 commits into from
Apr 2, 2025
Merged

Conversation

mbfreder
Copy link
Contributor

@mbfreder mbfreder commented Apr 1, 2025

Which issue(s) does this change fix?

cfn-lint changed their message (again) when a Lambda runtime is deprecated.

From Validate if lambda runtime is deprecated
Back to Check if EOL Lambda Function Runtimes are used

This PR reverts #7920

Why is this change necessary?

This

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mbfreder mbfreder requested a review from a team as a code owner April 1, 2025 23:26
@mbfreder mbfreder force-pushed the fix-validate-message branch from 0ca3c45 to 15487d3 Compare April 1, 2025 23:42
f"\\[\\[E2531: Validate if lambda runtime is deprecated\\] "
f"\\(Runtime '{runtime}' was deprecated on.*",
f"\\[\\[W2531: Check if EOL Lambda Function Runtimes are used] "
f"\\(Runtime \\'{runtime}'\\ was deprecated on.*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These \\ were removed before because they're not needed. You don't need to add them again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Updated. Thanks

@valerena
Copy link
Contributor

valerena commented Apr 2, 2025

Edit the PR name to start with test: so it gets a nice commit message when merged

@mbfreder mbfreder changed the title fix validate error message test: fix validate error message Apr 2, 2025
@mbfreder mbfreder enabled auto-merge April 2, 2025 23:04
@mbfreder mbfreder added this pull request to the merge queue Apr 2, 2025
Merged via the queue into aws:develop with commit 6ffb8a3 Apr 2, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants