only check response checksum for returned header #3374
Merged
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbera87
approved these changes
Apr 4, 2025
SergeyRyabinin
approved these changes
Apr 4, 2025
sbiscigl
force-pushed
the
response-checksum
branch
from
a11526f to
447f0fc
Compare
jeking3
reviewed
Apr 7, 2025
| for (const auto& hashIterator : request->GetResponseValidationHashes()) | ||
| { | ||
| std::stringstream headerStr; | ||
| headerStr<<"x-amz-checksum-"<<hashIterator.first; |
There was a problem hiding this comment.
An improvement here would be to embed the c string representation of the header into the hash class, avoiding a stringstream to string to c string for every buffer that arrives.
jeking3
reviewed
Apr 7, 2025
| @@ -246,13 +246,19 @@ namespace Aws | |||
| } | |||
|
|
|||
| //TODO: handle the read rate limiter here, once back pressure is setup. | |||
| assert(response); | |||
| for (const auto& hashIterator : request->GetResponseValidationHashes()) | |||
There was a problem hiding this comment.
An improvement here would be to delay hash initialization until it's first used, as workloads that use lots of requests on small data sets will have a lower files/s throughput potential if we initialize them all up front.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Only updates response validation hashes for the first checksum in the response
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.