Protocol tests generate suites with request input setting #3376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
added a commit
that referenced
this pull request
Apr 9, 2025
SergeyRyabinin
commented
Apr 9, 2025
There was a problem hiding this comment.
Note: 1 test client has been removed as the originally added c2j test client model definition was corrupted in source and added by mistake.
SergeyRyabinin
added a commit
that referenced
this pull request
Apr 9, 2025
SergeyRyabinin
force-pushed
the
sr/pt/gen
branch
from
c262f0d to
33112c8
Compare
sbiscigl
approved these changes
Apr 9, 2025
| @@ -22,20 +24,21 @@ | |||
| import java.io.IOException; | |||
| import java.io.StringWriter; | |||
| import java.nio.charset.StandardCharsets; | |||
| import java.util.ArrayList; | |||
| import java.util.List; | |||
| import java.util.*; | |||
There was a problem hiding this comment.
aahh, default IDE config.
| } | ||
| } | ||
|
|
||
| public ProtocolTestModel convert(C2jTestSuite c2jTestSuite) { |
There was a problem hiding this comment.
instead of creating a seperate Transformer class maybe it would be a good idea to call a function .from() on ProtocolTestModel that takes a C2J test suite as a model.
There was a problem hiding this comment.
I just followed the existing pattern within the project.
| /** | ||
| * A JSON hash representing the structure of the parsed response. Either this or error (not both) must appear in the test case. | ||
| */ | ||
| private Optional<JsonNode> result; |
There was a problem hiding this comment.
is there a way to model it? raw JsonNode should only be used if we cannot model it as a object.
sbera87
approved these changes
Apr 9, 2025
SergeyRyabinin
force-pushed
the
sr/pt/gen
branch
from
33112c8 to
57382d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Protocol tests WIP
Description of changes:
Continue working on the protocol tests generation.
This change adds generation of test suites with tests from the model, with client creation and request input filling.
This change follows 2 ideas:
Note: 1 test client has been removed as the originally added c2j test client model definition was corrupted in source and added by mistake.
Note: No response validation / no http mocking in this PR.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.