[C++] SDKs to track 3 feature Ids for S3 functionality #3506
+38
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
reviewed
Aug 5, 2025
| @@ -1504,4 +1504,4 @@ namespace Aws | |||
| } | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
removed new line in file without changing file
| @@ -52,6 +53,10 @@ XmlOutcome AWSXMLClient::MakeRequest(const Aws::AmazonWebServiceRequest& request | |||
| const char* signerRegionOverride /* = nullptr */, | |||
| const char* signerServiceNameOverride /* = nullptr */) const | |||
| { | |||
| // Add S3Express user agent feature if backend is S3Express | |||
| if (endpoint.GetAttributes() && endpoint.GetAttributes()->backend == "S3Express") { | |||
| const_cast<Aws::AmazonWebServiceRequest&>(request).AddUserAgentFeature(Aws::Client::UserAgentFeature::S3_EXPRESS_BUCKET); | |||
There was a problem hiding this comment.
why are we adding the cast const_cast<Aws::AmazonWebServiceRequest&> ? its not needed?
| EXPECT_FALSE(response.IsSuccess()); | ||
|
|
||
| // Verify S3_EXPRESS_BUCKET feature (value 6) was added | ||
| const auto& features = request.GetUserAgentFeatures(); |
There was a problem hiding this comment.
this isnt actually testing it the other user agent test captures the request that was seen in the http client -- this is not using the captured mock request, it is jsut using the request that you submitted to the s3 client
kai-ion
force-pushed
the
mato
branch
2 times, most recently
from
581d37f to
f5a8524
Compare
sbiscigl
approved these changes
Aug 7, 2025
- added S3_express_bucket tracking updated to only include tracking for s3_express updated to only include tracking for s3_express updated to only include tracking for s3_express updated to only include tracking for s3_express one level deeper to AWSXmlClient s3 unit test updated to only include tracking for s3_express one level deeper to AWSXmlClient updated to only include tracking for s3_express one level deeper to AWSXmlClient updated to only include tracking for s3_express one level deeper to AWSXmlClient Updated S3 unit test for correct user agent updated to only include tracking for s3_express one level deeper to AWSXmlClient Updated S3 unit test for correct user agent updated to only include tracking for s3_express one level deeper to AWSXmlClient Updated S3 unit test for correct user agent updated to only include tracking for s3_express one level deeper to AWSXmlClient Updated S3 unit test for correct user agent updated to only include tracking for s3_express one level deeper to AWSXmlClient Updated S3 unit test for correct user agent updated to only include tracking for s3_express one level deeper to AWSXmlClient Updated S3 unit test for correct user agent updated to only include tracking for s3_express one level deeper to AWSXmlClient Updated S3 unit test for correct user agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.