Skip to content

Conversation

@sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented Jan 7, 2026

Issue #, if available:

#3679

Description of changes:

Reverted to pre-refactor of chunked encoding to ONLY chunk encode for sigv4 requests. Chunk encoding broke mrap as it is a sigv4a client. This will behave the same as it did before.

Additionally a s3-control integration test was commented out, we are re-enabling it as it would have caught this.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review January 7, 2026 20:32
@sbiscigl sbiscigl merged commit 8320ed4 into main Jan 8, 2026
4 of 5 checks passed
@sbiscigl sbiscigl deleted the fix-mrap branch January 8, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants