Better exception messages #3699
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `ArgumentNullException` constructor takes as its argument the name of the offending parameter, not a free form error message. See https://learn.microsoft.com/en-us/dotnet/api/system.argumentnullexception.-ctor?view=net-9.0#system-argumentnullexception-ctor(system-string)
Contributor
|
Thanks for the contribution, but as you noticed (in #3704) this class has a bigger problem where it doesn't handle expired credentials, and updating the error message doesn't really improve things that much. I'll close this PR and we'll triage that issue instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error messages.
Description
In some cases when the SDK throws an exception, the error message is "Value cannot be null. (Parameter 'Options property cannot be empty: ClientName')". It should be "Value cannot be null. (Parameter 'ClientName')". The problem is caused by incorrect usage of
ArgumentNullExceptionconstructor.Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
License