Generate 9 more S3 Operations #3895
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generates 9 more operations to conclude phase 1. I had to add a customization to exclude members from property generation but not from the marshallers because of
PartDetail
which inherits fromPartETag
.PartETag
contains the excluded members.I also updated the
RestXmlExceptionUnmarshaller.tt
file to get theId2
andCfId
which is unique to S3, as well as update the exception shapes themselves to add the constructor which takes these values in its constructor.One change from this is that
PutBucketPolicy
's payload is set torequest.Content
instead ofrequest.ContentStream
. I've done a sanity check to make sure it still works. Per the model since the payload is a string, there is no need to wrap it in a memory stream. Also the payload member doesn't target the streaming trait so there is no need to stream it either.One other minor change is that
Tagging
inPutBucketTagging
was automatically initialized if it was null. This was a one-off customization we had that I intentionally left out to remove another customization hook. If we feel we want this added back, we can do that, but I will call this out as a breaking change.Motivation and Context
Testing
DRY_RUN-2df7b27d-b938-44c2-aa9d-64c1ce797bf7
executed successfully with flipping request.ContentStream to request.Content
Screenshots (if appropriate)
Types of changes
Checklist
License