-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Generate HTML doc from Notebooks #569
WIP: Generate HTML doc from Notebooks #569
Conversation
dd1ec14
to
81b78de
Compare
I did a checkout in your branch and built it locally, I loved it!
|
Also, readthedocs doesn't run our build script currently, so we will need to figure out a way to generate the link-files there. Maybe calling the script from the Makefile?? |
The link files are now created with the help of a local Sphinx extension. However |
# Conflicts: # requirements-dev.txt
Awesome!
I will try find out some solution 🤔 |
I've also tried to use some different libraries ( |
Maybe setting up the readthedocs environment with Anaconda could work: https://nbsphinx.readthedocs.io/en/0.8.1/usage.html?highlight=pandoc#Using-conda |
Seems a good alternative. Could you add an equivalent file into your branch please? I've created a specific branch to receive your PR. It will reflect here. |
Anaconda setup for readthedocs
The current setup should work but is still missing adjustments to navigation, formatting, etc. |
It will not trigger automatically from the PR, I will need to merge it into the target branch. |
Can I merge it? You can open a second one later with the tweaks. |
Yes I think you can merge it to see if it actually works. |
Awesome! It worked! |
Could you open another PR, please? We will point it to main now. |
Yes I will create another one. Do you think we should point the links in the README and docstrings to the docs page or leave them pointing to GitHub? |
Thank you! 👏
Makes sense to me. p.s. Don't forget to update the |
Issue #551:
Description of changes:
I've tried to add a first draft for generating HTML docs out of the existing notebooks. However this approach has two major downsides:
nbsphinx
,nbsphinx-link
,IPython
andpandoc
)Nevertheless the generation works more or less (some CSS finetuning probably required) and the Notebooks are included in the generated docs. So maybe this state can server as a starting point for discussion.
PS: @igorborgest There were some leading whitespaces copy-paste "errors" in #562. These are also fixed in this PR but I can also create a separate one for that.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.