add retries for node validations #428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxesn
reviewed
Mar 27, 2025
tatlat
force-pushed
the
node-validation-retry
branch
from
8157640 to
5fe11f1
Compare
g-gaston
reviewed
Mar 27, 2025
| ) | ||
| var pods *corev1.PodList | ||
| consecutiveErrors := 0 | ||
| err = wait.PollUntilContextTimeout(ctx, nodeValidationInterval, nodeValidationTimeout, true, func(ctx context.Context) (bool, error) { |
internal/node/validations.go
Outdated
Comment on lines
20
to
21
| nodeValidationInterval = 30 * time.Second | ||
| nodeValidationTimeout = 5 * time.Minute |
There was a problem hiding this comment.
Are this random values or we have some reason behind them?
There was a problem hiding this comment.
Those were random placeholders while I test. I'm going to change it to 5 second intervals and 1 minute timeout. Since it stops after 5 consecutive errors, 1 minute makes sense since it allows for up to 6 retries assuming there's no delay in getting nodes. 5 seconds should be enough time for transient issues to resolve without polling too frequently.
There was a problem hiding this comment.
If it turns out that's not enough, we can increase the duration in the future.
tatlat
force-pushed
the
node-validation-retry
branch
from
5fe11f1 to
c89abc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.