Dockerized E2E testing #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Jurredr merged 98 commits into main from jurredr/dockerized-testing

Jun 11, 2025

Contributor

Jurredr commented Feb 11, 2025 •

edited

Loading

Changed

Introduced Dockerized E2E testing to mainly combat the issue of minor environment discrepancies, where snapshot generation outputs differ based on the OS and environment they were generated on. Specifically;

Changed playwright-jest to @playwright/test
Implemented parallel test running
E2E tests always run in Dockerized environment
Updated CI script for e2e to build and run in Docker
Added test reporting with results at the end of e2e CI run
Fixed numerous issues in existing tests

Tests (NA)

I have tested this change on VSCode
I have tested this change on JetBrains

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Jurredr requested a review from a team as a code owner

February 11, 2025 14:36

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/e2e.yml Fixed Show fixed Hide fixed

.github/workflows/e2e.yml Fixed Show fixed Hide fixed

.github/workflows/new_pr.yml Fixed Show fixed Hide fixed

dogusata reviewed

View reviewed changes

ui-tests/playwright.config.ts Outdated Show resolved Hide resolved

Jurredr changed the title ~~Test PR for testing new Dockerized testing~~ Dockerized E2E testing

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/e2e.yml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/lint.yml Dismissed Show dismissed Hide dismissed

.github/workflows/new_pr.yml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/e2e.yml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/e2e.yml Fixed Show fixed Hide fixed

.github/workflows/e2e.yml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/e2e.yml Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/e2e.yml Fixed Show fixed Hide fixed

Jurredr added 20 commits

May 23, 2025 17:56


          Modified e2e docker script and added local e2e testing script

b0fdd35


          Added dockerfile for E2E testing

76476b1


          Added trace npm scripts for Playwright tracing

22267a6


          Renamed docker image and container names

444723f


          Updated node version in Dockerfile

868ec44


          Added separate npm script for building docker image

5647dc6


          Changed trace mode to upload traces for each failed test

e552750


          Added JUnit xml reporter to Playwright

09dfc65


          Updated Docker run command

bb1b7d6


          Added command to inspect Docker E2E test results

e554eca


          Changed docker inspect target name to "flarechatui-e2e-container"

78fba85


          Added docker clean script / step to container runner

79525d2


          Removed test results / last run file from default ui-tests dir

dfe6c1f


          Added JUnit reporter for Playwright

41499bf


          Migrated jest-playwright to playwright/test

f05517f


          Added test reports to git ignore

f8bce54


          Generate all test results in one separate root directory

a507ce4


          Ignore Dockerfile from eslint

793ac81


          Use npm install instead of ci in docker image

17172e2


          Test fixes for playwright library migration

2cf1335

Jurredr added 3 commits

May 28, 2025 12:27


          Improved docker caching behavior

7d6994f


          Added golden snapshots

f4400a6


          Updated snapshots

8043ddd

dogusata previously approved these changes

View reviewed changes


          Attempt at splitting chromium and webkit

e6c7bf7

Jurredr dismissed dogusata’s stale review via

e6c7bf7

May 28, 2025 12:18

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/e2e.yml Fixed Show fixed Hide fixed

.github/workflows/e2e.yml Fixed Show fixed Hide fixed

.github/workflows/e2e.yml Fixed Show fixed Hide fixed

.github/workflows/e2e.yml Fixed Show fixed Hide fixed

.github/workflows/e2e_chromium.yml Fixed Show fixed Hide fixed

.github/workflows/e2e_webkit.yml Fixed Show fixed Hide fixed

Jurredr added 3 commits

May 28, 2025 14:31


          Use GitHub container registry for caching

f265ae9


          Fixed test reporter

b734eb6


          Increased test timeout to 30000ms, updated snapshots

d7d416c

github-advanced-security bot found potential problems

View reviewed changes

.github/workflows/e2e-linux.yml Dismissed Show dismissed Hide dismissed

.github/workflows/new_pr.yml Dismissed Show dismissed Hide dismissed

.github/workflows/new_pr.yml Dismissed Show dismissed Hide dismissed

Jurredr added 2 commits

May 28, 2025 15:18


          Snapshot updated for failing tests

db192aa


          Removed 'only' test

ecee4af

dogusata requested changes

View reviewed changes

Contributor

dogusata left a comment

fix snapshots with wront unicoding.

Jurredr added 11 commits

June 10, 2025 15:08


          Force E2E unicode to utf-8 and fix some viewport issues

922e48b


          Fixed open tabs test by adding animation wait

97582a6


          Merge branch 'main' into jurredr/dockerized-testing


          Updated all snapshots


          Attempt at fixing docker issues on github

23380c6


          Testing fixed followup test

af3776f


          Changed playwright version in Dockerfile to non arm64

e00679c


          Updated playwright Docker version

ce52d49


          Enabled all tests again, changed platform to arm64

307d4b8


          Fix follow ups test, hide scroll down button in tests

b349b9a


          Fixed welcome mode test

2c0272d

Jurredr merged commit 39113d1 into main

7 checks passed

Jurredr deleted the jurredr/dockerized-testing branch

June 11, 2025 14:25

Jurredr self-assigned this

Jurredr added the testing label

laileni-aws mentioned this pull request

Bumping up mynah version to 4.35.4 #363

Merged

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing