Skip to content

Added separate border color to input #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Conversation

dogusata
Copy link
Collaborator

by @awschristou: #340

Problem

  • in themes where the default background color matches (or is similar to) the input box background, you cannot see the input box boundary
  • when the input box has focus, its default color is a gradient scheme. UX direction wants this to be a standard border color

Solution

  • allow hosts to define border colors for the input box, both for when the box has focus and when it doesn't:
    • mynah-color-text-input-border - the color of the input box border when the box does not have focus
    • mynah-color-text-input-border-focused - the color of the input box border when it does have focus
  • these new styles have been given default values, so that:
    • the non-focused box appearance matches the current behavior (border matches background color)
    • the focused box appearance uses the default border color (no more gradient)

Screenshots

Before - left: unfocused input (can't see boundary), right: focused input (gradient)

image

After - left: unfocused input, right: focused input (both with sample colors)

image

Tests

  • I have tested this change in the sample theme builder that is run with npm run dev

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dogusata dogusata requested a review from a team as a code owner May 30, 2025 05:57
@dogusata dogusata merged commit 1f3d303 into main May 30, 2025
7 checks passed
@dogusata dogusata deleted the dogusata/input-border-color branch May 30, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant