Use Neptune Export Service Job Id as default exportId if available #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreachild
reviewed
Mar 27, 2025
src/main/java/com/amazonaws/services/neptune/cli/AbstractTargetModule.java
Show resolved
Hide resolved
andreachild
reviewed
Mar 28, 2025
src/main/java/com/amazonaws/services/neptune/cli/AbstractTargetModule.java
Show resolved
Hide resolved
|
LGTM |
xiazcy
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updates the default export ID to look for an AWS Batch job id in the environment. If found, it will be used, otherwise a random UUID is generated. When running Neptune Export via the export service stack, the Batch ID in the environment matches the service Job Id. This is the same mechanism currently used to name Neptune cluster clones.
Testing:
I have tested the changes in a test deployment of the Neptune Export service stack. I've verified that the jobId is correctly propagated all the way to the S3 upload by default, and that a custom export id is propagated all the way to S3 if it is explicitly overridden by the export params.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.