chore(ci): cargo timing cb job #2525
Conversation
|
Are we aiming to replace the existing one? https://github.com/aws/s2n-quic/actions/runs/13798807727/job/38596692024?pr=2525 s2n-quic/.github/workflows/ci.yml Line 671 in c8de638 Or I guess what's the overlap? |
There was a problem hiding this comment.
Hi @dougch, I like the idea to put this script in mainline S2N-QUIC. It gives our team more control on the metrics than using your personal branch. In addition to my comments, please also respond to @camshaft's question.
Also, is this PR ready for review? I thought it's still a draft but you did request review from me. Thanks!
codebuild/spec/cargotiming.yml
Outdated
| - cargo build --timings | ||
| post_build: | ||
| commands: | ||
| - cargo test --exclude s2n-quic-platform --workspace |
There was a problem hiding this comment.
Is there a particular reason to exclude tests on the s2n-quic-platform crate? Are you trying to skip ipv4_test and ipv4_two_socket_test because of those two don't run on CodeBuild? If we have to skip those two tests, can we just skip those two tests without skip testing for the entire crate? What's the effect by skipping this on the metrics that this script generated?
codebuild/spec/cargotiming.yml
Outdated
| variables: | ||
| # This assumes you have a Rust toolchain installed | ||
| CARGO: "cargo +nightly" | ||
| RUST_TOOLCHAIN: "1.74.1-x86_64-unknown-linux-gnu" |
There was a problem hiding this comment.
Is there a RUST_TOOLCHAIN that's closer to our current MSRV: 1.71.0?
Release Summary:
Resolved issues:
n/a
Description of changes:
Checks in a CodeBuild buildspec for a
cargo buildtiming job. The report at the end is uploaded to s3, example: https://d2vvhsim0lzm9u.cloudfront.net/cargotiming/cargo-timing.htmlCall-outs:
The job is scheduled to run once a day, and the metrics are used to track cargo build historical timing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.