Skip to content

change: adding eu-central-2 bucket info to JS constants #4907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2024
Merged

change: adding eu-central-2 bucket info to JS constants #4907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d26c2b
change: adding eu-central-2 bucket info to JS constants
Oct 22, 2024
1fb761c
change: adding zrh image uris for dji neuronx
Oct 22, 2024
86693e2
Merge branch 'master' into change-zrh-js-buckets
ErnevSharma Oct 22, 2024
5bff245
Merge branch 'master' into change-zrh-js-buckets
ErnevSharma Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/sagemaker/image_uri_config/djl-neuronx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"cn-north-1": "727897471807",
"cn-northwest-1": "727897471807",
"eu-central-1": "763104351884",
"eu-central-2": "380420809688",
"eu-west-1": "763104351884",
"eu-west-3": "763104351884",
"sa-east-1": "763104351884",
Expand All @@ -37,6 +38,7 @@
"cn-north-1": "727897471807",
"cn-northwest-1": "727897471807",
"eu-central-1": "763104351884",
"eu-central-2": "380420809688",
"eu-west-1": "763104351884",
"eu-west-3": "763104351884",
"sa-east-1": "763104351884",
Expand All @@ -59,6 +61,7 @@
"cn-north-1": "727897471807",
"cn-northwest-1": "727897471807",
"eu-central-1": "763104351884",
"eu-central-2": "380420809688",
"eu-west-1": "763104351884",
"eu-west-3": "763104351884",
"sa-east-1": "763104351884",
Expand All @@ -81,6 +84,7 @@
"cn-north-1": "727897471807",
"cn-northwest-1": "727897471807",
"eu-central-1": "763104351884",
"eu-central-2": "380420809688",
"eu-west-1": "763104351884",
"eu-west-3": "763104351884",
"sa-east-1": "763104351884",
Expand All @@ -103,6 +107,7 @@
"cn-north-1": "727897471807",
"cn-northwest-1": "727897471807",
"eu-central-1": "763104351884",
"eu-central-2": "380420809688",
"eu-west-1": "763104351884",
"eu-west-3": "763104351884",
"sa-east-1": "763104351884",
Expand All @@ -125,6 +130,7 @@
"cn-north-1": "727897471807",
"cn-northwest-1": "727897471807",
"eu-central-1": "763104351884",
"eu-central-2": "380420809688",
"eu-west-1": "763104351884",
"eu-west-3": "763104351884",
"sa-east-1": "763104351884",
Expand All @@ -147,6 +153,7 @@
"cn-north-1": "727897471807",
"cn-northwest-1": "727897471807",
"eu-central-1": "763104351884",
"eu-central-2": "380420809688",
"eu-west-1": "763104351884",
"eu-west-3": "763104351884",
"sa-east-1": "763104351884",
Expand All @@ -169,6 +176,7 @@
"cn-north-1": "727897471807",
"cn-northwest-1": "727897471807",
"eu-central-1": "763104351884",
"eu-central-2": "380420809688",
Copy link
Member

@malav-shastri malav-shastri Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any E2E tests covering this file? we should probably trigger those before merging.

"eu-west-1": "763104351884",
"eu-west-3": "763104351884",
"sa-east-1": "763104351884",
Expand Down
5 changes: 5 additions & 0 deletions src/sagemaker/jumpstart/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,11 @@
gated_content_bucket="jumpstart-private-cache-prod-eu-central-1",
neo_content_bucket="sagemaker-sd-models-prod-eu-central-1",
),
JumpStartLaunchedRegionInfo(
region_name="eu-central-2",
content_bucket="jumpstart-cache-prod-eu-central-2",
gated_content_bucket="jumpstart-private-cache-prod-eu-central-2",
),
Comment on lines 70 to +77
Copy link
Contributor

@AWS-pratab AWS-pratab Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the neo bucket not needed for this region?

Copy link
Contributor Author

@ErnevSharma ErnevSharma Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to description: Adding JS bucket info. I verified through the Neo RIP service that their bucket is not available as of yet.

Copy link
Contributor

@JGuinegagne JGuinegagne Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then should you remove the neo bucket?

JumpStartLaunchedRegionInfo(
region_name="eu-north-1",
content_bucket="jumpstart-cache-prod-eu-north-1",
Expand Down
Loading