Skip to content

Shlex quote #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Shlex quote #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sagemaker_training/process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ async def run_async(cmd, processes_per_host, env, cwd, stderr, **kwargs):
Raises:
error_class: If there is an exception raised when creating the process.
"""
cmd = " ".join(cmd)
cmd = " ".join(six.moves.shlex_quote(token) for token in cmd)
proc = await asyncio.create_subprocess_shell(
cmd, env=env, cwd=cwd, stdout=PIPE, stderr=stderr, **kwargs
)
Expand Down Expand Up @@ -255,7 +255,7 @@ def _create_command(self):
six.moves.shlex_quote(arg) # pylint: disable=too-many-function-args
for arg in self._args
]
return ["/bin/sh", "-c", '"./%s %s"' % (self._user_entry_point, " ".join(args))]
return ["/bin/sh", "-c", "./%s %s" % (self._user_entry_point, " ".join(args))]

def _python_command(self): # pylint: disable=no-self-use
return [python_executable()]
Expand Down