Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update identity test to not rely on comparing pointers to zero-sized objects #574

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

Madrigal
Copy link
Contributor

@Madrigal Madrigal commented Mar 5, 2025

Issue #, if available:
#568

Description of changes:
Changes coming to Go 1.25 may break existing tests (see issue for more details) Updating how we do comparisons in the test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Madrigal Madrigal merged commit a5fc2c6 into main Mar 5, 2025
11 checks passed
@Madrigal Madrigal deleted the fix-update-unit-test-zero-value-comp branch March 5, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants