Python: Fix type annotations in KMS client methods #7520
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`kms_client.encrypt` returns type `bytes`. Updated method signatures for encrypt and decrypt. The "Plaintext" returned from `kms_client.decrypt` is also `bytes`, but it should be decoded to `str` to match the parameter type of the encrypt method.
github-actions
bot
added
the
Python
brmur
added
the
Task
tejasgn1
reviewed
Jul 25, 2025
| @@ -75,7 +75,7 @@ def decrypt(self, key_id: str, cipher_text: str) -> bytes: | |||
| try: | |||
| return self.kms_client.decrypt(KeyId=key_id, CiphertextBlob=cipher_text)[ | |||
| "Plaintext" | |||
| ] | |||
| ].decode() | |||
There was a problem hiding this comment.
Hi, we don't need use the decode() method here as that is being taken care of on line 201. Having the method returns an error. The other changes look good to me.
There was a problem hiding this comment.
I removed the redundant call to decode() on line 201. The call to decode() should be inside the decrypt() function, making its signature the inverse of encrypt(). Since encode() is called from encrypt(), it makes sense that decode() would be called in decrypt().
tejasgn1
requested changes
Jul 25, 2025
I removed the redundant call to decode() on line 201. The call to decode() should be inside the decrypt() function, making its signature the inverse of encrypt(). Since encode() is called from encrypt(), it makes sense that decode() would be called in decrypt().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated encrypt/decrypt method signatures to properly handle bytes return types from KMS client operations.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.