Skip to content

Fix: Lock can be acquired after lease duration if the current owner has been terminated unexpectedly when using skipBlockingWait=true #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix: Lock can be acquired after lease duration if the current owner has been terminated unexpectedly when using skipBlockingWait=true #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79c8d7c
Fix for issue: https://github.com/awslabs/amazon-dynamodb-lock-client…
chris-ryan-square May 26, 2022
dd38ec5
Add the actual test
chris-ryan-square May 26, 2022
ca2c8d5
Catch exception to map to Optional.empty()
chris-ryan-square May 30, 2022
f1b2736
formatting
chris-ryan-square May 30, 2022
064ace8
Fix: Need to use currentTimeMillis for lock times as comparisons on …
chris-ryan-square Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
.settings/*
target/*
.project
.classpath
.classpath
.idea
24 changes: 14 additions & 10 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
<jdk.version>1.8</jdk.version>

<!-- build toolchain -->
<maven.assembly.plugin.version>3.1.1</maven.assembly.plugin.version>
<maven.compiler.plugin.version>3.8.0</maven.compiler.plugin.version>
<maven.assembly.plugin.version>3.3.0</maven.assembly.plugin.version>
<maven.compiler.plugin.version>3.9.0</maven.compiler.plugin.version>
<maven.dependency.plugin.version>3.1.1</maven.dependency.plugin.version>
<maven.enforcer.plugin.version>3.0.0-M2</maven.enforcer.plugin.version>
<maven.gpg.plugin.version>1.6</maven.gpg.plugin.version>
Expand All @@ -31,23 +31,23 @@
<maven.source.plugin.version>3.0.1</maven.source.plugin.version>

<!-- compile dependencies -->
<aws.java.sdk.version>2.3.5</aws.java.sdk.version>
<netty.version>[4.1.59.Final,)</netty.version>
<aws.java.sdk.version>2.17.198</aws.java.sdk.version>
<netty.version>[4.1.77.Final,)</netty.version>
<commons-logging.version>1.2</commons-logging.version>

<!-- test dependencies -->
<dynamodblocal.version>1.11.119</dynamodblocal.version>
<dynamodblocal.version>1.15.0</dynamodblocal.version>
<mockito.version>2.23.0</mockito.version>
<powermock.version>2.0.0</powermock.version>
<hamcrest.version>1.3</hamcrest.version>
<bytebuddy.version>1.9.3</bytebuddy.version>

<!-- test toolchain -->
<junit.version>4.13.1</junit.version>
<log4j-core.version>2.17.1</log4j-core.version>
<maven.surefire.version>3.0.0-M3</maven.surefire.version>
<maven.failsafe.version>3.0.0-M3</maven.failsafe.version>
<docker.maven.plugin.version>0.28.0</docker.maven.plugin.version>
<junit.version>4.13.2</junit.version>
<log4j-core.version>2.17.2</log4j-core.version>
<maven.surefire.version>3.0.0-M5</maven.surefire.version>
<maven.failsafe.version>3.0.0-M5</maven.failsafe.version>
<docker.maven.plugin.version>0.38.1</docker.maven.plugin.version>
<build.profile.id>dev</build.profile.id>
<integration-test.category>*/BasicLockClientTests.java,*/GetAllLocksTests.java,*/GetLocksByPartitionKeyTest.java,*/ConsistentLockDataStressTest.java</integration-test.category>

Expand All @@ -60,6 +60,10 @@
<jacoco-aggregate-destFile>${project.build.directory}/coverage-reports/aggregate.exec</jacoco-aggregate-destFile>
</properties>
<developers>
<developer>
<name>Chris Ryan</name>
<email>[email protected]</email>
</developer>
<developer>
<name>Justin Lin</name>
<email>[email protected]</email>
Expand Down
Loading