Skip to content

Support Dual-Stack STUN Servers and IPv6 srflx Candidates #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: release-v1.12.1
Choose a base branch
from

Conversation

stefankiesz
Copy link
Contributor

@stefankiesz stefankiesz commented Apr 25, 2025

Issue #, if available:
N/A

What was changed?

  • Enabled support for IPv6 srflx candidates.
  • Added support for dual-stack STUN servers.
  • ICE server structs now maintain two IP addresses per server: IPv4 and IPv6.
    • If the STUN server is not dual-stack, then only the IPv4 address will be set.
    • If the ICE server is a TURN server, then only the IPv4 address will be set.
  • All TURN server functionality remains unchanged, it is only using the IPv4 address of the new DualKvsIpAddresses struct.
  • Dual-stack peers using dual-stack STUN servers gather both IPv4 and IPv6 srflx candidates, allowing for cross-network-type connections between dual-stack and IPv4-only peers.

Why was it changed?

  • IPv6 srflx candidates were enabled to prepare for dual-stack STUN service support.
  • Dual-stack STUN server support was added to allow for peers on dual-stack networks using dual-stack STUN servers to connect with peers on IPv4-only networks. Previously, only IPv6 srflx candidates would have been gathered when dual-stack peers used dual-stack STUN servers which would not be viable for connection with IPv4-only peers.

How was it changed?

  • IPv6 srflx candidates were enabled were enabled by removing the filtering out of local IPv6 STUN candidates from being initialized.
  • Dual-stack STUN server support was added by maintaining two IP addresses for dual-stack STUN servers and creating srflx candidates from both, so remote peers can try connections across both IP families.

What testing was done for the changes?

  • CI to pass.
  • Unit tests with dual-stack server resolution to be added once service support is enabled.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@stefankiesz stefankiesz marked this pull request as ready for review April 29, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants