Skip to content

Add tests for getIpAddrStr #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add tests for getIpAddrStr #2123

wants to merge 1 commit into from

Conversation

sirknightj
Copy link
Contributor

Issue #, if available:

  • N/A

What was changed?

  • Unit tests were added for GetIpAddrStr in Network.c

Why was it changed?

  • According to codecov, this method is already covered, however I was unable to locate a test that validated correctness of the out parameter buffer.
  • Since we rely on logs heavily during debugging, want to add additional checks to make certain that the IP addresses printed are correct and never accidentally broken in the future.

How was it changed?

  • Added additional checks for getIpAddrStr, which is a toString for the IP addresses.

What testing was done for the changes?

  • Ran the tests locally, they pass. Source code wasn't touched.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sirknightj sirknightj changed the base branch from release-v1.12.1 to develop May 7, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants