Issue 429 #446
Open
Issue 429 #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 30, 2020 15:57
jimomulloy
requested review from
etsung-aws,
jiyou95,
MynockSpit and
skylarbemus
as code owners
|
Any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #429
In Version 4.0.x - when creating a devportal (in developer mode) I see errors in the StaticAssetUploaderLambdaFunction console and the stack does not complete create.
See the error logs documented in the issue notes.
See also my subsequent comments appealing for a response for this.
This PR is an attempt to fix that - please correct if you have a better solution, thanks.
*Description of changes:
When is DevelopmentMode: true, it seems if I remove the PublicAccessBlockConfiguration: fromr the S3 buckets. e.g., DevPortalSiteS3Bucket then it works OK
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.