Fix warnings found by the Undefined Behavior Sanitizer #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes runtime error warnings found when running the tests with the undefined behavior sanitizer enabled. "runtime error: call to function aws_byte_cursor_eq through pointer to incorrect function type 'bool (*)(const void *, const void *)'" Signed-off-by: Björn Svensson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes runtime error warnings found when running the tests with the undefined behavior sanitizer enabled.
Description of changes:
Add a callback function that uses correct signature aws_hash_callback_eq_fn (as seen in aws-c-mqtt).
Since the CI-build is not using
-fno-sanitize-recover=all, and the warnings are recoverable they will not fail the CI build.The warnings are also found when a user incorporates
aws-sdk-cppinto a project and build it using an UB sanitizer.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.