Make aws_byte_cursor_from_string NULL tolerant (#1187)

awslabs · Feb 12, 2025 · 6401c83 · 6401c83
1 parent bfa6c85
commit 6401c83
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/include/aws/common/string.h b/include/aws/common/string.h
@@ -325,6 +325,7 @@ bool aws_byte_buf_write_from_whole_string(
 
 /**
  * Creates an aws_byte_cursor from an existing string.
+ * If the src is NULL, it returns an empty cursor
  */
 AWS_COMMON_API
 struct aws_byte_cursor aws_byte_cursor_from_string(const struct aws_string *src);

diff --git a/source/string.c b/source/string.c
@@ -416,7 +416,12 @@ bool aws_byte_buf_write_from_whole_string(
  * Creates an aws_byte_cursor from an existing string.
  */
 struct aws_byte_cursor aws_byte_cursor_from_string(const struct aws_string *src) {
-    AWS_PRECONDITION(aws_string_is_valid(src));
+    if (!src) {
+        struct aws_byte_cursor cursor;
+        AWS_ZERO_STRUCT(cursor);
+        return cursor;
+    }
+
     return aws_byte_cursor_from_array(aws_string_bytes(src), src->len);
 }