Skip to content

Conversation

DmitriyMusatkin
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@graebm
Copy link
Contributor

graebm commented Nov 29, 2024

hehe, it's PR #312
which is a recent python version

'pkg_install': 'apt-get -qq install -y',
'variables': {
'python': "python3.8",
'python': "python3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just explaining why this explicitly said "python3.8"...
This was set 2 years ago, in this PR: #198

back then, on some of our docker images, installing "python3" would get you python 3.6, but you could get something newer by specifying "python3.8"

We've probably stopped using those super old images, so this makes sense.
But do a census to be sure...

There are still a few other places we specify python version, if you want to do a search for "python3."

'pkg_install': 'zypper install -y',
'variables': {
'python': "python3.9",
'python': "python3",
Copy link
Contributor

@graebm graebm Nov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on opensuse/leap:15.3 that we're currently using, python3 == python3.6

maybe we should be updating the docker image too, so that "python3" gets us a recent version again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants