Skip to content

Commit

Permalink
Fix segfaults -- CRC64NVME on machines with disabled AVX and uri pars…
Browse files Browse the repository at this point in the history
…ing corner case (#119)
  • Loading branch information
TingDaoK authored Jan 28, 2025
1 parent 3e1e4c8 commit 711fa66
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions Makefile.frag
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

INT_DIR=$(builddir)/build/install
CMAKE_BUILD_DIR=$(builddir)/cmake_build
GENERATE_STUBS=$(shell expr `$(PHP_EXECUTABLE) --version | head -1 | cut -f 2 -d' '` \>= 7.1)
GENERATE_STUBS=$(shell expr `php --version | head -1 | cut -f 2 -d' '` \>= 7.1)

CMAKE = cmake3
ifeq (, $(shell which cmake3))
Expand Down Expand Up @@ -63,13 +63,13 @@ $(builddir)/ext/awscrt.c: $(CMAKE_BUILD_DIR)/aws-crt-ffi-static/libaws-crt-ffi.a
$(srcdir)/ext/awscrt_arginfo.h: $(srcdir)/ext/awscrt.stub.php $(srcdir)/gen_stub.php
ifeq ($(GENERATE_STUBS),1)
# generate awscrt_arginfo.h
$(PHP_EXECUTABLE) $(srcdir)/gen_stub.php --minimal-arginfo $(srcdir)/ext/awscrt.stub.php
php $(srcdir)/gen_stub.php --minimal-arginfo $(srcdir)/ext/awscrt.stub.php
endif

# transform/install api.h from FFI lib
$(srcdir)/ext/api.h: $(srcdir)/crt/aws-crt-ffi/src/api.h
# generate api.h
$(PHP_EXECUTABLE) $(srcdir)/gen_api.php $(srcdir)/crt/aws-crt-ffi/src/api.h > $(srcdir)/ext/api.h
php $(srcdir)/gen_api.php $(srcdir)/crt/aws-crt-ffi/src/api.h > $(srcdir)/ext/api.h

# install api.h to ext/ as well
$(builddir)/ext/api.h : $(srcdir)/ext/api.h
Expand Down

0 comments on commit 711fa66

Please sign in to comment.