Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bit rot in GitHub workflows #61

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Fix bit rot in GitHub workflows #61

merged 5 commits into from
Jun 12, 2024

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Jun 12, 2024

Issue:

  1. The osx CI broke, because GitHub's macos-latest runner changed from being x64 to being arm64. macos arm64 doesn't support older Ruby versions.

  2. Some CI runs broke due to installing the latest bundler, which no longer works with Ruby 2.x

Description of changes:

  1. Always use explicit runner versions, so CI doesn't unexpectedly break on us as frequently. I.e. macos-latest -> macos-14
  2. Now that arm64 macos runners are available, actually run tests on them (instead of just a cross-compile)
  3. Don't manually install bundler. The latest version doesn't work with Ruby 2.x. The setup-ruby action was already handling installing a compatible version

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@graebm graebm changed the title Add arm64 macos tests to GitHub workflow Fix bit rot in GitHub workflows Jun 12, 2024
@graebm graebm marked this pull request as ready for review June 12, 2024 22:43
@graebm graebm requested a review from alextwoods June 12, 2024 22:45
@graebm graebm merged commit f1663ab into main Jun 12, 2024
14 checks passed
@graebm graebm deleted the fix-ci branch June 12, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants