Cognito credential provider support #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-swift into cognito_support
sbSteveK
reviewed
Mar 12, 2025
| @@ -76,7 +138,7 @@ extension CredentialsProvider { | |||
| } | |||
|
|
|||
| extension CredentialsProvider.Source { | |||
|
|
|||
There was a problem hiding this comment.
There are a large number of weird white space additions onto empty lines. Is this an auto formatting issue?
sbSteveK
approved these changes
Mar 12, 2025
waahm7
reviewed
Mar 19, 2025
| @@ -0,0 +1,9 @@ | |||
| import Builder | |||
|
|
|||
| class CrtCiPrepXCodebuild(Builder.Action): | |||
There was a problem hiding this comment.
Can we merge this provider to Main instead of iot branch? Swift SDK might need this as well. (I haven't reviewed the PR)
There was a problem hiding this comment.
Not needed, if we are merging IoT branch to main in Q2.
There was a problem hiding this comment.
Yes, we're merging the IoT branch into main in Q2. If you have time, I'd really appreciate a review! I'd love to get more perspectives on this PR. 🚀
xiazhvera
commented
Mar 19, 2025
| @@ -6,8 +6,8 @@ on: | |||
| - 'main' | |||
|
|
|||
| env: | |||
| BUILDER_VERSION: v0.9.73 | |||
| BUILDER_SOURCE: releases | |||
| BUILDER_VERSION: xcodebuild_setup | |||
There was a problem hiding this comment.
This would need to be updated once crt-builder is merged. Currently the crt-builder has CI failure related to gcc-8.
waahm7
reviewed
Mar 20, 2025
Source/AwsCommonRuntimeKit/auth/credentials/CredentialsProvider.swift
Outdated
Show resolved
Hide resolved
Source/AwsCommonRuntimeKit/auth/credentials/CredentialsProvider.swift
Outdated
Show resolved
Hide resolved
Source/AwsCommonRuntimeKit/auth/credentials/CredentialsProvider.swift
Outdated
Show resolved
Hide resolved
Test/AwsCommonRuntimeKitTests/auth/CredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
Test/AwsCommonRuntimeKitTests/auth/CredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
Test/AwsCommonRuntimeKitTests/auth/CredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The PR added support for cognito credential provider.
It also depends on latest crt-builder to enable the environment variables for xcodebuild test. awslabs/aws-crt-builder#314
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.