Build Ci fix

.github/workflows/build.yml

@@ -41,15 +41,15 @@ jobs:
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.ubuntu.x64.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.ubuntu.x64.${{ env.PACKAGE_NAME }}.build.static"
           path: |
             ./build/${{ env.PACKAGE_NAME }}
       - name: Archive setup files
         uses: actions/upload-artifact@v4
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.ubuntu.x64.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.ubuntu.x64.${{ env.PACKAGE_NAME }}.setup.static"
           path: |
             ./setup/
 
@@ -81,15 +81,15 @@ jobs:
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.amazonlinux.x64.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.amazonlinux.x64.${{ env.PACKAGE_NAME }}.build.static"
           path: |
             ./build/${{ env.PACKAGE_NAME }}
       - name: Archive setup files
         uses: actions/upload-artifact@v4
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.amazonlinux.x64.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.amazonlinux.x64.${{ env.PACKAGE_NAME }}.setup.static"
           path: |
             ./setup/
 
@@ -121,15 +121,15 @@ jobs:
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.rhel.x64.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.rhel.x64.${{ env.PACKAGE_NAME }}.build.static"
           path: |
             ./build/${{ env.PACKAGE_NAME }}
       - name: Archive setup files
         uses: actions/upload-artifact@v4
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.rhel.x64.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.rhel.x64.${{ env.PACKAGE_NAME }}.setup.static"
           path: |
             ./setup/
 
@@ -215,15 +215,15 @@ jobs:
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.linux.armhf.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.linux.armhf.${{ env.PACKAGE_NAME }}.build.static"
           path: |
             ./build/${{ env.PACKAGE_NAME }}
       - name: Archive setup files
         uses: actions/upload-artifact@v4
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.linux.armhf.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.linux.armhf.${{ env.PACKAGE_NAME }}.setup.static"
           path: |
             ./setup/
 
@@ -255,15 +255,15 @@ jobs:
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.linux.mips.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.linux.mips.${{ env.PACKAGE_NAME }}.build.static"
           path: |
             ./build/${{ env.PACKAGE_NAME }}
       - name: Archive setup files
         uses: actions/upload-artifact@v4
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.linux.mips.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.linux.mips.${{ env.PACKAGE_NAME }}.setup.static"
           path: |
             ./setup/
 
@@ -295,15 +295,15 @@ jobs:
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.linux.aarch64.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.linux.aarch64.${{ env.PACKAGE_NAME }}.build.static"
           path: |
             ./build/${{ env.PACKAGE_NAME }}
       - name: Archive setup files
         uses: actions/upload-artifact@v4
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.linux.aarch64.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.linux.aarch64.${{ env.PACKAGE_NAME }}.setup.static"
           path: |
             ./setup/
 
@@ -335,15 +335,15 @@ jobs:
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.linux.ppc64.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.linux.ppc64.${{ env.PACKAGE_NAME }}.build.static"
           path: |
             ./build/${{ env.PACKAGE_NAME }}
       - name: Archive setup files
         uses: actions/upload-artifact@v4
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.linux.ppc64.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.linux.ppc64.${{ env.PACKAGE_NAME }}.setup.static"
           path: |
             ./setup/
 
@@ -375,15 +375,15 @@ jobs:
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.linux.ppc64le.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.linux.ppc64le.${{ env.PACKAGE_NAME }}.build.static"
           path: |
             ./build/${{ env.PACKAGE_NAME }}
       - name: Archive setup files
         uses: actions/upload-artifact@v4
         # Run for main branch only
         if: github.ref == 'refs/heads/main'
         with:
-          name: "DC.linux.ppc64le.${{ env.PACKAGE_NAME }}.static"
+          name: "DC.linux.ppc64le.${{ env.PACKAGE_NAME }}.setup.static"
           path: |
             ./setup/
 

source/SharedCrtResourceManager.cpp

@@ -227,10 +227,10 @@ int SharedCrtResourceManager::buildClient(const PlainConfig &config)
             "logging::enable-sdk-logging in your configuration file");
     }
 
-    eventLoopGroup = unique_ptr<EventLoopGroup>(new EventLoopGroup(
-        1 // The number of threads used depends on your use-case. IF you have a maximum of less than
-          // a few hundred connections 1 thread is the ideal threadCount.
-        ));
+    eventLoopGroup = unique_ptr<EventLoopGroup>(
+        new EventLoopGroup(1 // The number of threads used depends on your use-case. IF you have a maximum of less than
+                             // a few hundred connections 1 thread is the ideal threadCount.
+                           ));
     if (!eventLoopGroup)
     {
         // cppcheck-suppress nullPointerRedundantCheck

source/shadow/ConfigShadow.cpp

@@ -25,7 +25,7 @@ constexpr char ConfigShadow::TAG[];
 constexpr char ConfigShadow::DEFAULT_CONFIG_SHADOW_NAME[];
 constexpr int ConfigShadow::DEFAULT_WAIT_TIME_SECONDS;
 
-void ConfigShadow::updateLocalConfigFile(PlainConfig &config, const char *configFilePath) const
+void ConfigShadow::updateLocalConfigFile(const PlainConfig &config, const char *configFilePath) const
 {
     ofstream configFile(configFilePath);
     JsonObject jsonObj;
@@ -411,7 +411,7 @@ void ConfigShadow::resetClientConfigWithJSON(
         {
             LOGM_WARN(TAG, "User-level config file does not exist: %s", userConfig.c_str());
         }
-    
+
         // Check and update system-level config file
         if (FileUtils::FileExists(Config::DEFAULT_SYSTEM_CONFIG_FILE))
         {
@@ -420,7 +420,10 @@ void ConfigShadow::resetClientConfigWithJSON(
         }
         else
         {
-            LOGM_WARN(TAG, "System-level config file does not exist or permission denied to open: %s", Config::DEFAULT_SYSTEM_CONFIG_FILE);
+            LOGM_WARN(
+                TAG,
+                "System-level config file does not exist or permission denied to open: %s",
+                Config::DEFAULT_SYSTEM_CONFIG_FILE);
         }
     }
 }

source/shadow/ConfigShadow.h

@@ -206,7 +206,7 @@ namespace Aws
                      * @param config device client local configuration
                      * @param configFilePath absolute file path of device client configuration
                      */
-                    void updateLocalConfigFile(PlainConfig &config, const char *configFilePath) const;
+                    void updateLocalConfigFile(const PlainConfig &config, const char *configFilePath) const;
                 };
             } // namespace Shadow
         } // namespace DeviceClient

source/tunneling/SecureTunnelingContext.cpp

@@ -197,25 +197,30 @@ namespace Aws
                     }
 
                     LOGM_DEBUG(TAG, "SecureTunnelingContext::OnTcpForwardDataReceive data.len=%zu", data.len);
-                    const size_t MAX_CHUNK_SIZE = 32768; 
+                    const size_t MAX_CHUNK_SIZE = 32768;
                     size_t offset = 0;
                     size_t total_sent = 0;
-                
+
                     while (offset < data.len)
                     {
                         size_t chunk_size = std::min(MAX_CHUNK_SIZE, data.len - offset);
                         Aws::Crt::ByteCursor chunk = aws_byte_cursor_from_array(data.buffer + offset, chunk_size);
                         int result = mSecureTunnel->SendData(chunk);
                         if (result != AWS_OP_SUCCESS)
                         {
-                            LOGM_ERROR(TAG, "Failed to send data block to secure tunnel. Block size: %zu, Total bytes sent: %zu, Total size: %zu", 
-                                       chunk_size, total_sent, data.len);
+                            LOGM_ERROR(
+                                TAG,
+                                "Failed to send data block to secure tunnel. Block size: %zu, Total bytes sent: %zu, "
+                                "Total size: %zu",
+                                chunk_size,
+                                total_sent,
+                                data.len);
                             break;
                         }
                         offset += chunk_size;
                         total_sent += chunk_size;
                     }
-                
+
                     if (total_sent == data.len)
                     {
                         LOGM_INFO(TAG, "Successfully sent data block. Total bytes sent: %zu", total_sent);

test/config/TestConfigSerialization.cpp

@@ -68,7 +68,8 @@ TEST(SerializeConfigTestFixture, SerializeCompleteConfigTest)
 		}
 	},
     "config-shadow": {
-        "enabled": true
+        "enabled": true,
+        "persistent-update": false
       },
     "sample-shadow": {
         "enabled": true,
@@ -168,7 +169,8 @@ TEST(SerializeConfigTestFixture, SerializeBasicConfigTest)
         }
     },
     "config-shadow": {
-        "enabled": true
+        "enabled": true,
+        "persistent-update": false
     },
     "sample-shadow": {
         "enabled": true

test/jobs/TestJobsFeature.cpp

@@ -702,9 +702,8 @@ TEST_F(TestJobsFeature, InvalidJobDocument)
         *jobsMock,
         publishUpdateJobExecutionStatusWithRetry(
             JobExecutionEq(job),
-            StatusInfoEq(
-                JobsFeature::JobExecutionStatusInfo(
-                    Iotjobs::JobStatus::REJECTED, "Unable to execute job, invalid job document provided!", "", "")),
+            StatusInfoEq(JobsFeature::JobExecutionStatusInfo(
+                Iotjobs::JobStatus::REJECTED, "Unable to execute job, invalid job document provided!", "", "")),
             _,
             _))
         .Times(1);

test/logging/TestLogQueue.cpp

@@ -24,12 +24,10 @@ class LogQueueTest : public ::testing::Test
     void SetUp() override
     {
         logQueue = unique_ptr<LogQueue>(new LogQueue);
-        logQueue->addLog(
-            unique_ptr<LogMessage>(
-                new LogMessage(LogLevel::DEBUG, "TAG", std::chrono::system_clock::now(), "Message 1")));
-        logQueue->addLog(
-            unique_ptr<LogMessage>(
-                new LogMessage(LogLevel::DEBUG, "TAG", std::chrono::system_clock::now(), "Message 2")));
+        logQueue->addLog(unique_ptr<LogMessage>(
+            new LogMessage(LogLevel::DEBUG, "TAG", std::chrono::system_clock::now(), "Message 1")));
+        logQueue->addLog(unique_ptr<LogMessage>(
+            new LogMessage(LogLevel::DEBUG, "TAG", std::chrono::system_clock::now(), "Message 2")));
     }
 
   public:

test/util/TestFileUtils.cpp

@@ -92,9 +92,8 @@ TEST(FileUtils, handlesEmptyPathForStoreValueInFile)
 
 TEST(FileUtils, testStoreValueInFile)
 {
-    ASSERT_TRUE(
-        FileUtils::StoreValueInFile(
-            "This file was created as part of testStoreValueInFile unit test.", "/tmp/testStoreValueInFile.txt"));
+    ASSERT_TRUE(FileUtils::StoreValueInFile(
+        "This file was created as part of testStoreValueInFile unit test.", "/tmp/testStoreValueInFile.txt"));
 }
 
 TEST(FileUtils, assertsCorrectFilePermissions)