Skip to content

feat: Checksum reuse between retries in chunked streaming requests #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2025

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented Jul 9, 2025

Companion PR:

Issue #

3359

Description of changes

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@@ -46,7 +48,8 @@ extension HTTPRequestBuilder {
signingConfig: signingConfig,
previousSignature: signature,
trailingHeaders: trailingHeaders,
checksumString: checksumString
checksumString: checksumString,
context: context
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only thing I am thinking about is whether passing the context around is bad, but it shouldnt really be too large

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a reference type, it's easy to pass around.

The real concern is avoiding reference cycles since Context holds references to so many things...

@jbelkins
Copy link
Contributor

Tested in Xcode Instruments for memory leakage. Confirmed that there are none, approving.

@sichanyoo sichanyoo merged commit 9c79917 into main Jul 18, 2025
31 checks passed
@sichanyoo sichanyoo deleted the feat/reuse-checksum-in-retries branch July 18, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants