feat: Checksum reuse between retries in chunked streaming requests #1980
+187
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntegration test for it.
Merged
2 tasks
dayaffe
approved these changes
Jul 11, 2025
dayaffe
reviewed
Jul 11, 2025
| @@ -46,7 +48,8 @@ extension HTTPRequestBuilder { | |||
| signingConfig: signingConfig, | |||
| previousSignature: signature, | |||
| trailingHeaders: trailingHeaders, | |||
| checksumString: checksumString | |||
| checksumString: checksumString, | |||
| context: context | |||
There was a problem hiding this comment.
the only thing I am thinking about is whether passing the context around is bad, but it shouldnt really be too large
There was a problem hiding this comment.
It's a reference type, it's easy to pass around.
The real concern is avoiding reference cycles since Context holds references to so many things...
jbelkins
approved these changes
Jul 14, 2025
|
Tested in Xcode Instruments for memory leakage. Confirmed that there are none, approving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR:
Issue #
3359
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.