Skip to content

Commit

Permalink
Disable fast-fast for end-to-end tests in CI (#295)
Browse files Browse the repository at this point in the history
Fail-fast causes some testing resources to leak if one of tests fails.
We disable it to ensure all testing resources are properly cleaned up.

---

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

Signed-off-by: Burak Varlı <[email protected]>
  • Loading branch information
unexge authored Nov 15, 2024
1 parent f8cc674 commit b9387ac
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/e2e-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ jobs:
test:
needs: build
strategy:
# Failing fast causes some resources created during the test to leak,
# so we disable it to ensure all resources created during test are properly cleaned up.
fail-fast: false
matrix:
cluster-type: ["eksctl", "kops"]
arch: ["x86", "arm"]
Expand Down

0 comments on commit b9387ac

Please sign in to comment.