Update readdirplus metric to use histogram instead of counter #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mansi Pandey <[email protected]>
mansi153
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
mansi153
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
mansi153
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
mansi153
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
mansi153
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
mansi153
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
mansi153
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
requested changes
Feb 5, 2025
| @@ -225,7 +225,7 @@ where | |||
| match block_on(self.fs.readdirplus(parent, fh, offset, replier).in_current_span()) { | |||
| Ok(_) => { | |||
| reply.ok(); | |||
| metrics::counter!("fuse.readdirplus.entries").increment(count as u64); | |||
| metrics::histogram!("fuse.readdirplus.entries").record(count as f64); | |||
There was a problem hiding this comment.
We should make the same change for the readdir operation, as well as readdirplus. I missed that in the original issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update readdirplus API's
fuse.readdirplus.entriesmetric to use histogram instead of counter, as it would make more sense to record statistics on how many entries were returned in a readdirplus request when there was more than one in a given interval, than recording the total readdirplus entries per interval.Addresses #1236.
Does this change impact existing behavior?
Yes, the
fuse.readdirplus.entriesmetric type has been changed.Does this change need a changelog entry? Does it require a version change?
No, it is only updating a metric. Since metric names and availability are considered unstable, this does not need a changelog entry or version change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).