Bump env_logger to latest version
#1313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`humantime`, a dependency of `env_logger`, is unmaintained. Latest version of `env_logger` switches maintained `jiff` crate to provide the same functionality. See https://rustsec.org/advisories/RUSTSEC-2025-0014 Signed-off-by: Burak Varlı <[email protected]>
dannycjones
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
LGTM.
I think what we should do here is merge this (using squash) onto the base branch (fuser/fork). That'll be a new patch on top. Then we can run the vendor script and make a PR for main. (cc @ujinho)
|
CI is failing but seems to be formatting issues. When we PR to main, licensing checks should go ahead and it should be fine. |
|
Will wait for upstream PR to get merged, meanwhile, to unblock the CI, updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
humantime, a dependency ofenv_logger, is unmaintained. Latest version ofenv_loggerswitches maintainedjiffcrate to provide the same functionality.See https://rustsec.org/advisories/RUSTSEC-2025-0014
Upstream PR cberner/fuser#330
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).