Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[allow(clippy::new_without_default)] for Once #147

Merged
merged 1 commit into from
May 14, 2024

Conversation

bkragl
Copy link
Contributor

@bkragl bkragl commented May 14, 2024

fixes clippy error https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@sarsko sarsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the correct fix; Once is not Default. Correct fix would be to #[allow(clippy::new_without_default)].

@bkragl bkragl changed the title impl Default for Once #[allow(clippy::new_without_default)] for Once May 14, 2024
@jorajeev jorajeev merged commit fa007fb into awslabs:main May 14, 2024
5 checks passed
@bkragl bkragl deleted the once-default branch May 14, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants