Release tough 0.20.0 #867
Merged
Release tough 0.20.0 #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Korczynski <[email protected]>
Update metadata validation: must not skip versions, must measure expiration relative to start of update. TUF specification v1.0.33, sections 5.1 and 5.3.5.
Do not follow cyclic or redundant edges in the delegated roles graph. TUF specification v1.0.33, section 5.6.7.1.
In the pre-order depth-first search for target metadata, if a delegated role is selected, is terminating, and does not have metadata for the target, end the search. TUF specification v1.0.33 section 5.6.7.2.1.
The version number of the snapshot metadata in the previous timestamp metadata must be less than or equal to the version number in the new timestamp metadata. TUF specification v1.0.33 section 5.4.3.2.
For each role in a previous snapshot, the role must be present in the new snapshot and must have a version greater than or equal to the version in the previous snapshot. TUF specification v1.0.33 section 5.5.5.
When either the timestamp or snapshot keys are rotated, delete any cached timestamp and snapshot metadata. TUF specification v1.0.33 section 5.3.11.
Require unique keyids in an objects signatures. TUF specification v1.0.33 section 4.2.1.
Use .context to simplify error propagation when we do not find an expected matafiles key. Use the expect attribute rather than allow for deterministic clippy findings.
Introduce the private method find_target_from_role to incorporate two arguments used in the recursive search (specification 5.6.7), and call that from the public method find_target.
Signed-off-by: Sean P. Kelly <[email protected]> Signed-off-by: Martin Harriman <[email protected]> Signed-off-by: Patrick J.P. Culp <[email protected]>
cbgbt
force-pushed
the
release-tough-0.20.0
branch
from
6abc367 to
81f8b1c
Compare
ginglis13
approved these changes
Mar 27, 2025
jpculp
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.