Add PKCE support #314
Merged
Add PKCE support #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
npm testlocally and all tests are passing.PR Description
This PR implements #218 which adds support for PKCE, both plain and SHA256-hashed code_verifier. It is based on the RFC and should be more-or-less compliant with it.
However, it is implemented as an opt-in approach (which means that it does not support OAuth2.1 since there PKCE is always mandatory. But that was not required for the task either I assume).
This means that if the requests does not have anything related to PKCE in them, then everything works as before.
Attribution
This PR is merely a squash and minimal code cleanup from PR #245 (thanks @tanettrimas!)