Fix CI Action #14
Merged
Fix CI Action #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update version of `flake8` in `pre-commit` config - `importlib_metadata` in higher versions of python removes deprecated endpoint that is used by older `flake8` in `pre-commit` - also update the push Action workflow to be more consistent across the jobs regarding versions of stuff
|
Turns out there is a deeper cause to the At some point, numpy (or pandas?) changed how New approach to conversion that I just force-pushed uses the library API so it should be slightly more bulletproof. ( |
- numpy changed how timestamps are parsed into datetime64 - old conversion relied on the units being `ns` - this caused the conversion from `ms` to result in many 0 time deltas - dividing by 0 produced `inf` and attempting `int(inf)` raised an Error - now use numpy API to convert to `s`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://axds.atlassian.net/browse/ATN-717
flake8dependency issue by updating it's version inpre-commitconfigint(math.inf)inbufr.pynot sure if this is actually a good behavior: I cap the number tosys.maxsizebefore conversion to intinfis introduced when calculating drift and distance > 0 and time delta = 0 (on encoding/wildlife_computers.py:76)maybe replacinginfwithnanright at the source would be better? I don't know the usage context so I'm not sure.