[pull] main from areal-project:main#71
Merged
Merged
Conversation
* fix(proxy): refuse default admin key on non-loopback bind
The proxy rollout server previously accepted the well-known
DEFAULT_ADMIN_API_KEY ('areal-admin-key') and only logged a warning,
even when bound to a non-loopback interface (--host defaults to
0.0.0.0, which is then resolved to the host's IP). Any attacker
reachable on the network could authenticate to admin endpoints
(grant_capacity, start_session, export_trajectories) using this
public default value.
_setup_openai_client now raises RuntimeError when the resolved
server host is not a loopback address and the configured admin key
is still the documented default. Local single-host development is
unaffected; operators who knowingly accept the risk in a trusted
environment can set AREAL_ALLOW_DEFAULT_ADMIN_KEY=1.
* address review: validate admin key before global assign; bind uvicorn to configured host
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )